savvato-software / tribe-app-backend

3 stars 20 forks source link

TRIB-233: fixes bug in ToBeReviewedCheckerServiceImpl #234

Closed mrsbluerose closed 2 months ago

mrsbluerose commented 2 months ago

after updating to Spring Boot 3.3.1, some checks are less forgiving ToBeReviewedCheckerServiceImpl was throwing the following bug:

java.lang.IllegalArgumentException: method GET must not have a request body.
    at okhttp3.Request$Builder.method(Request.kt:258) ~[okhttp-4.12.0.jar:na]
    at org.springframework.http.client.OkHttp3ClientHttpRequest.executeInternal(OkHttp3ClientHttpRequest.java:88) ~[spring-web-6.1.10.jar:6.1.10]
    at org.springframework.http.client.AbstractStreamingClientHttpRequest.executeInternal(AbstractStreamingClientHttpRequest.java:70) ~[spring-web-6.1.10.jar:6.1.10]
    at org.springframework.http.client.AbstractClientHttpRequest.execute(AbstractClientHttpRequest.java:66) ~[spring-web-6.1.10.jar:6.1.10]
    at org.springframework.web.client.RestTemplate.doExecute(RestTemplate.java:889) ~[spring-web-6.1.10.jar:6.1.10]
    at org.springframework.web.client.RestTemplate.execute(RestTemplate.java:790) ~[spring-web-6.1.10.jar:6.1.10]
    at org.springframework.web.client.RestTemplate.exchange(RestTemplate.java:672) ~[spring-web-6.1.10.jar:6.1.10]
    at com.savvato.tribeapp.services.ToBeReviewedCheckerServiceImpl.getWordDetails(ToBeReviewedCheckerServiceImpl.java:70) ~[classes/:na]

Fix:

codecov[bot] commented 2 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 82.72%. Comparing base (2bea792) to head (af88534).

Additional details and impacted files ```diff @@ Coverage Diff @@ ## develop #234 +/- ## ========================================== Coverage 82.72% 82.72% Complexity 557 557 ========================================== Files 79 79 Lines 1696 1696 Branches 274 274 ========================================== Hits 1403 1403 Misses 254 254 Partials 39 39 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

haxwell commented 2 months ago

I've merged down to all feature branches, as well.