sawhney17 / logseq-bionic-speedreader

MIT License
23 stars 1 forks source link

feat(settings): :sparkles: added setting keys for fixation and saccade #1

Closed calbch closed 2 years ago

calbch commented 2 years ago

users are now able to set a fixation and saccade value via the plugin settings

sawhney17 commented 2 years ago

Awesome! Looks great.

I think you can delete lines 4 and 5 as those variables are now unused.

calbch commented 2 years ago

kept them in in case you planned something for them in the future. But now that I know you don't need it I will remove them! will submit a new pull requests with some refactoring in a second.

sawhney17 commented 2 years ago

Great job! Merging!