sawsen11 / jrfonseca

Automatically exported from code.google.com/p/jrfonseca
0 stars 0 forks source link

setup.py version is based on install time, not pypi upload time (patch included) #105

Closed GoogleCodeExporter closed 9 years ago

GoogleCodeExporter commented 9 years ago
When I "python -m pip install gprof2dot", gprof2dot's setup.py installs itself 
with a version string derived from the current date, not the version string 
uploaded to pypi:

$ python -m pip install -v -v -v gprof2dot
  Downloading from URL http://[devpi pypi mirror]/gprof2dot-2014.03.12.tar.gz#md5=4e520475d52e7b95fd0c7e9d28c5bedd (from http://[devpi pypi mirror]/+simple/gprof2dot/)
  Running setup.py (path:c:\[pip_build]\gprof2dot\setup.py) egg_info for package gprof2dot
    Running command python setup.py egg_info
    running egg_info
    creating pip-egg-info\gprof2dot.egg-info
[...]
  Requested gprof2dot==2014.03.12, but installing version 2014.09.01
Installing collected packages: gprof2dot
  Running setup.py install for gprof2dot

This is not what's intended, I think.

This patch fixes the problem:

$ diff -uw setup.py setup.py.new
--- setup.py    2014-09-02 09:18:55.549160600 +0100
+++ setup.py.new        2014-09-01 18:44:58.845701000 +0100
@@ -17,7 +17,7 @@

 setup(
     name='gprof2dot',
-    version=time.strftime('%Y.%m.%d'),
+    version="2014.03.12",
     author='Jose Fonseca',
     author_email='jose.r.fonseca@gmail.com',
     url='https://code.google.com/p/jrfonseca/wiki/Gprof2Dot',

Original issue reported on code.google.com by mar...@martindengler.com on 2 Sep 2014 at 8:21

GoogleCodeExporter commented 9 years ago
See #106

Original comment by Jose.R.F...@gmail.com on 29 Sep 2014 at 11:12