sawsen11 / jrfonseca

Automatically exported from code.google.com/p/jrfonseca
0 stars 0 forks source link

[gprof2dot] pull request: module name improvement #87

Open GoogleCodeExporter opened 9 years ago

GoogleCodeExporter commented 9 years ago
in our large project, gprof2dot would label many modules as "__init__", which 
isn't very helpful.

This branch tries to present a non-ambiguous modulename.
I'm not sure what you need to do a pull on google code, so I'll provide Too 
Much Information:

 * my fork -- https://code.google.com/r/buck-gprof2dot/
 * the revision -- https://code.google.com/r/buck-gprof2dot/source/detail?r=99c78fc2c1be07f2c9e7fb963c1aeedac0943dfb
 * the diff -- https://code.google.com/r/buck-gprof2dot/source/diff?spec=svn99c78fc2c1be07f2c9e7fb963c1aeedac0943dfb&r=99c78fc2c1be07f2c9e7fb963c1aeedac0943dfb&format=side&path=/gprof2dot.py

Original issue reported on code.google.com by b...@yelp.com on 30 Oct 2013 at 7:32

GoogleCodeExporter commented 9 years ago
This is similar to what was proposed in issue #75.

The problem with both proposals is that this won't work reliably when the 
profiled app runs on a different python version than gprof2dot.

Still, I realize it's better than what we have now, so I'll try to get it in.

Original comment by Jose.R.F...@gmail.com on 4 Nov 2013 at 7:31

GoogleCodeExporter commented 9 years ago
In the worst case it will give the filenames for modules that can't be found 
locally.

Original comment by b...@yelp.com on 4 Nov 2013 at 7:35

GoogleCodeExporter commented 9 years ago
bump :)

I just ran with this patch applied in a setting which couldn't import the 
modules, and it resulted in the full filename being used in the label, as 
designed. It gave me very good insight into what what going on.

Original comment by b...@yelp.com on 23 Jan 2014 at 10:49

GoogleCodeExporter commented 9 years ago

Original comment by Jose.R.F...@gmail.com on 13 Mar 2015 at 7:14