search

sawyerpollard / MineWeather

Chrome Extension that displays a Minecraft scene on New Tabs depending on local weather conditions.
https://chrome.google.com/webstore/detail/mineweather/gklgaaagldobfcacmhhbnbgofohfgneb
67 stars 11 forks source link

Fix #17 #18

Open SunnyMonster123 opened 3 years ago

SunnyMonster123 commented 3 years ago

I swapped the font file out because for some reason the old one is a little bit offset. And I can see some padding fixes in the css to fix the font. The new font file is not offset anymore and I restored the padding. I changed the line height to 1.2em so that the text wraps properly.

sawyerpollard commented 3 years ago

Thank you for this pull request! I'm going to check them out this weekend.

sawyerpollard commented 2 years ago

I kinda like the font that's being used right now! But the issue with the wrapping is really weird. You think changing the line height fixes it?

SunnyMonster123 commented 2 years ago

Hi, sorry for the very late reply, I've been quite busy recently. The old font file has a weird issue of the glyphs rendering off-center vertically so you fixed it by setting the line height to 0 and manually adding paddings to separate two lines of text. That padding doesn't get applied between lines of the same text element though. The new font I found doesn't seem to have the same problem so I restored the line height and reduced the padding.

I've tested it on my computer and it should fix the problem.