Closed WithOpenEyes closed 1 year ago
Thanks for taking the time to open another issue, I appreciate it.
I'm trying to (in combination with sidedish) make it so the catalogue appears in a masonry layout:
Recently I even have it so thumbnails in the catalogue prefetch their full size OP and replace it automatically.
But I do agree, there is still a place for the 2.2.1 layout (that is, defined rows and long threads are cut off - heck I'm not even sure if I supported the full card to appear on hover - I should if I don't).
Come the holidays I'll definitely put this behind a toggle/option to switch between masonry and defined rows (which is the default 4chan X option).
You might want to stick with 2.2.1 if that's the case - I don't currently have any fallbacks implemented if certain options are/aren't enabled.
As always, if there's anything else that doesn't work with your workflow please let me know because AFAIK I'm the only one using the style so if it works for me, I won't know if it breaks for someone else. Same with any nice to have features.
Let me know how 2.2.5
goes.
Hi, thank you for updating and including the catalogue toggle in 2.2.5
Default-Esque looks great with how threads are displayed into single row/column for smaller/ Double row/column for larger with the expand on feature. A few issues I've noticed are.
There are smalls gaps that aren't an issue but tend to be really noticeable towards the bottom of a page
On boards where one size of thread becomes much more consistent like /vg/, after hiding all the smaller threads, larger threads were displayed without any issues.
While it offers two distinct appeals, those being :a row by row uniform approach to organisation which might be easier for some people to process information & For boards that feature long opening posts like /vg/,/t/. On text intensive boards like /adv/ masonry looks fine whereas usecases like /vg/ and /t/ are somewhat rarer on the website as whole. It might be better to simply force one size, either a smaller or larger card for default-esque depending on how trying creating a uniform style is.
Masonry I like masonry more in this version, it displays more consistently, and I think it looks very nice. For the average board, which is made up of both large and small thread, it displays them perfectly. Occasionally one column will stack threads towards the end, but it's hardly an issue as the threads are still plainly readable. Occasionally it will display weird padding between threads, but a refresh of the page will usually fix that. Ironically, it comes with the (buggy) name but is less buggy than default-esque.
In terms of issues besides the catalogue. I can't really think of any. When you added the new icons to favourite a thread, I think my icon wouldn't display properly. I was going to make that an issue, but I saw you had already created one, that and I swapped to the star which displayed fine. I'm using Firefox dev, which may or may not be relevant. with Violentmonkey and stylus. Thanks again for the update and happy holidays.
Thank you for all this detail.
Also just curious, do you have the filters for "long" threads or threads with lots of new lines?
I didn't actually test replies on hover in masonry mode, will have to do that too.
I think I know the issue - Firefox supports CSS Grid masonry
, so maybe it's applying as intended, rather than being a workaround as in Chrome. I'll have to test in Firefox.
Another issue I think exists is that switching modes doesn't sometimes make/apply the change correctly. For example, going from paged view to catalog view, then switching from masonry to default-esque.
That also makes me think that hiding a thread from the catalog doesn't "redraw" the grid, which would also cause issues.
I should make "watch thread" an option to appear in catalog mode, cause at the moment it only appears in within the menu.
le edit: the transform
I apply when hovering ruins the menu positioning, going to have to use negative margins (gross)
I'll keep looking into it. Thank you again so much.
Also just curious, do you have the filters for "long" threads or threads with lots of new lines?
Just as you suspected I did have comment filters ; I was using the ones suggested in the readme.md The culprits seem to be:
/^\W(\w+\b\W){91,149}$/;op:only;top:no;highlight:thread--extra-long /^\W(\w+\b\W){150,}$/;op:only;top:no;highlight:thread--silly-long /(?:[^\n]*(\n+)){5,}/;op:only;top:no;highlight:thread--new-lines
Upon commenting them out, Default-esque displayed all thread cards as small or large depending on the selection at the top of the Catalog and had no issues. I apologise, it's really something I should have remembered to check. Catalog small | Catalog Large |
---|---|
The first comment filter
/^\W(\w+\b\W){50,90}$/;op:only;top:no;highlight:thread--long
Seems to now be superfluous as well, but having it neither breaks default-esque nor does it cause any changes i've been able to notice. Masonry seems to operate properly regardless of those comment filters being active or not.
As far as I can tell, Catalog hover expand replies aren't functional, in default or masonry. Thread stacking at bottom of board | screenshot 2 |
---|---|
Top half | Bottom Half |
Masonry works very well and in worse case I'd just switch to a chromium based browser if Firefox ever was the cause of a large problem. But having done some brief testing in Edge I think they are operating the same.
Another issue I think exists is that switching modes doesn't sometimes make/apply the change correctly. For example, going from paged view to catalog view, then switching from masonry to default-esque.
I can't speak about paged to Catalog, I'm more likely to swap via the header. The few times I tried it, it worked anticipated.
Masonry -> Default | Default -> Masonry |
---|---|
Yeah, as you've said, it can result in some interesting layouts, but a Catalog refresh seems to rectify any issue one has after these swaps.
A separate issue I've found is on paged when enable board title and banner option is disabled, the Catalog bar becomes inaccessible due to the page scrolling down past it, you can collasp a thread, and it becomes accessible again ; the bar won’t scroll down past it. It operates normally with the board title and banner option enabled, not scrolling past it.
Thank you very much for adding the default-esque format to the Catalog. It's very much appreciated.
Post the navigation rail update, the catalog threads are displayed differently, I'm not sure if it's user error on my part, but I did look through the settings and I do not think I've overlooked a setting for how threads are displayed. The above picture is the latest user style version 2.2.4; The below the previous before navigation rail Version 2.2.1 In my opinion, 2.2.4 looks less appealing on certain boards with long-running threads or text intensive opening posts and was wondering if the option to return to the previous more uniform style was available or if it's a toggle I did overlook.
Not a big issue, as one can give up the sleekness of the new navigation rail and simply revert to 2.2.1, I was just curious if it's a design decision or if I've overlooked something obvious. Thanks for creating and sharing the style.