saxifrage / caac-map

A Resource Map for the City as a Campus Project
http://cityasacampus.org/map/
0 stars 1 forks source link

we're getting duplicate assignments #72

Closed chadwhitacre closed 8 years ago

chadwhitacre commented 8 years ago

Reticketed from https://github.com/saxifrage/cityasacampus/pull/272.

screen shot 2015-10-23 at 4 37 30 pm

chadwhitacre commented 8 years ago
(Pdb) len(set(self.assignments.values()))
29
(Pdb) len(self.assignments)
33
(Pdb)
chadwhitacre commented 8 years ago
(Pdb) solution = dict(flatten(c))
(Pdb) pp tuple(sorted(solution.values()))
('carnegie-library-of-pittsburgh-the-labs-at-clp---main---robotics-workshop-with-girls-of-steel',
 'carnegie-mellon-create-lab-hummingbird-robotics-kit',
 'carnegie-mellon-robotics-academy-cs2n',
 'carnegie-mellon-robotics-academy-expedition-atlantis-',
 'carnegie-mellon-robotics-academy-robotc',
 'carnegie-mellon-robotics-academy-robotc',
 'carnegie-mellon-robotics-academy-robots-virtual-world',
 'carnegie-mellon-university--cookie-vs-creme---a-robotic-twist',
 'carnegie-mellon-university-rumbleblocks-',
 'carnegie-mellon-university-school-of-computer-science-leap-at-cmu',
 'carnegie-science-center-chain-reaction-contraption-contest',
 'carnegie-science-center-roboworld',
 'carnegie-science-center-roboworld-activities',
 'deep-local-nike-chalkbot',
 'digital-media-academy-online-fundamentals-of-programming',
 'diy-make-a-rube-goldberg-machine',
 'girls-of-steel-robotics-the-girls-of-steel-robotics',
 'greene-academy-advanced-robotics',
 'greene-academy-ev3-lego-robotics',
 'grow-a-generation-audacious-robotocists',
 'grow-a-generation-engineering-your-passion',
 'grow-a-generation-engineering-your-passion',
 'id-tech-intro-to-programming-with-scratch-and-javascript',
 'id-tech-java-programming',
 'lifelong-kindergarten-group-at-the-mit-media-lab-scratch',
 'pittsburgh-first-get-involved',
 'robocup-manuela-veloso---robocup-champion',
 'sarah-heinz-house-join-sharp',
 'sarah-heinz-house-join-sharp',
 'super-awesome-sylvia-watercolorbot',
 'super-awesome-sylvia-watercolorbot',
 'synn-labs-music-video-with-rube-goldberg-',
 'wilkinsburg-public-library-unmask---bristle-bot-racers')
(Pdb)
chadwhitacre commented 8 years ago
{'engineering': [('assemble-summer-dreamers',
                  'wilkinsburg-public-library-unmask---bristle-bot-racers'),
                 ('carnegie-library-of-pittsburgh-weekly-workshop-at-clp---allegheny',
                  'deep-local-nike-chalkbot'),
                 ('carnegie-mellon-robotics-academy-cs2n',
                  'carnegie-science-center-chain-reaction-contraption-contest'),
                 ('carnegie-mellon-robotics-academy-robotc',
                  'diy-make-a-rube-goldberg-machine')],
 'programming-robots': [('carnegie-mellon-university--cookie-vs-creme---a-robotic-twist',
                         'digital-media-academy-online-fundamentals-of-programming'),
                        ('carnegie-mellon-university-rumbleblocks-',
                         'id-tech-java-programming'),
                        ('carnegie-mellon-university-school-of-computer-science-leap-at-cmu',
                         'id-tech-intro-to-programming-with-scratch-and-javascript'),
                        ('deep-local-nike-chalkbot',
                         'carnegie-mellon-university-school-of-computer-science-leap-at-cmu'),
                        ('diy-make-a-rube-goldberg-machine',
                         'carnegie-mellon-robotics-academy-cs2n'),
                        ('id-tech-java-programming',
                         'lifelong-kindergarten-group-at-the-mit-media-lab-scratch')],
 'robot-interaction': [('carnegie-mellon-create-lab-hummingbird-robotics-kit',
                        'grow-a-generation-engineering-your-passion'),
                       ('carnegie-mellon-robotics-academy-robots-virtual-world',
                        'super-awesome-sylvia-watercolorbot'),
                       ('carnegie-science-center-chain-reaction-contraption-contest',
                        'carnegie-mellon-robotics-academy-robotc'),
                       ('carnegie-science-center-roboworld',
                        'sarah-heinz-house-join-sharp'),
                       ('carnegie-science-center-roboworld-activities',
                        'greene-academy-advanced-robotics'),
                       ('girls-of-steel-robotics-the-girls-of-steel-robotics',
                        'grow-a-generation-audacious-robotocists'),
                       ('greene-academy-ev3-lego-robotics',
                        'carnegie-mellon-university--cookie-vs-creme---a-robotic-twist'),
                       ('grow-a-generation-audacious-robotocists',
                        'carnegie-mellon-create-lab-hummingbird-robotics-kit'),
                       ('id-tech-intro-to-programming-with-scratch-and-javascript',
                        'grow-a-generation-engineering-your-passion'),
                       ('lifelong-kindergarten-group-at-the-mit-media-lab-scratch',
                        'carnegie-library-of-pittsburgh-the-labs-at-clp---main---robotics-workshop-with-girls-of-steel'),
                       ('super-awesome-sylvia-watercolorbot',
                        'greene-academy-ev3-lego-robotics'),
                       ('robocup-manuela-veloso---robocup-champion',
                        'carnegie-mellon-robotics-academy-robotc'),
                       ('grow-a-generation-engineering-your-passion',
                        'sarah-heinz-house-join-sharp'),
                       ('pittsburgh-first-get-involved',
                        'super-awesome-sylvia-watercolorbot'),
                       ('synn-labs-music-video-with-rube-goldberg-',
                        'pittsburgh-first-get-involved'),
                       ('walt-disney-animation-studios-big-hero-6',
                        'robocup-manuela-veloso---robocup-champion'),
                       ('wilkinsburg-public-library-unmask---bristle-bot-racers',
                        'girls-of-steel-robotics-the-girls-of-steel-robotics'),
                       ('sarah-heinz-house-join-sharp',
                        'carnegie-mellon-robotics-academy-robots-virtual-world')],
 'robots-101': [('carnegie-library-of-pittsburgh-the-labs-at-clp---main---robotics-workshop-with-girls-of-steel',
                 'synn-labs-music-video-with-rube-goldberg-'),
                ('carnegie-mellon-robotics-academy-expedition-atlantis-',
                 'carnegie-science-center-roboworld-activities'),
                ('christopher-atkeson-build-baymax',
                 'carnegie-mellon-robotics-academy-expedition-atlantis-'),
                ('digital-media-academy-online-fundamentals-of-programming',
                 'carnegie-mellon-university-rumbleblocks-'),
                ('greene-academy-advanced-robotics',
                 'carnegie-science-center-roboworld')]}
chadwhitacre commented 8 years ago
('carnegie-science-center-chain-reaction-contraption-contest',
 'carnegie-mellon-robotics-academy-robotc')
('robocup-manuela-veloso---robocup-champion',
 'carnegie-mellon-robotics-academy-robotc')

('carnegie-mellon-create-lab-hummingbird-robotics-kit',
 'grow-a-generation-engineering-your-passion')
('id-tech-intro-to-programming-with-scratch-and-javascript',
 'grow-a-generation-engineering-your-passion')

('carnegie-science-center-roboworld',
 'sarah-heinz-house-join-sharp')
('grow-a-generation-engineering-your-passion',
 'sarah-heinz-house-join-sharp')

('carnegie-mellon-robotics-academy-robots-virtual-world',
 'super-awesome-sylvia-watercolorbot')
('pittsburgh-first-get-involved',
 'super-awesome-sylvia-watercolorbot')
chadwhitacre commented 8 years ago

So ... we're not properly removing elements from _pool once they're assigned?

chadwhitacre commented 8 years ago

Looks like we have resources duplicated across pathways within the same topic:

{'engineering': ['wilkinsburg-public-library-unmask---bristle-bot-racers',
                 'synn-labs-music-video-with-rube-goldberg-',
                 'deep-local-nike-chalkbot',
                 'grow-a-generation-engineering-your-passion',
                 'carnegie-science-center-chain-reaction-contraption-contest',
                 'diy-make-a-rube-goldberg-machine',
                 'carnegie-science-center-roboworld-activities',
                 'super-awesome-sylvia-watercolorbot'],
 'programming-robots': ['digital-media-academy-online-fundamentals-of-programming',
                        'id-tech-java-programming',
                        'id-tech-intro-to-programming-with-scratch-and-javascript',
                        'carnegie-mellon-robotics-academy-robotc',
                        'carnegie-mellon-university-school-of-computer-science-leap-at-cmu',
                        'carnegie-mellon-robotics-academy-cs2n',
                        'sarah-heinz-house-join-sharp',
                        'lifelong-kindergarten-group-at-the-mit-media-lab-scratch'],
 'robot-interaction': ['greene-academy-advanced-robotics',
                       'carnegie-mellon-university--cookie-vs-creme---a-robotic-twist',
                       'carnegie-mellon-create-lab-hummingbird-robotics-kit',
                       'grow-a-generation-engineering-your-passion',
                       'carnegie-mellon-robotics-academy-robotc',
                       'greene-academy-ev3-lego-robotics',
                       'pittsburgh-first-get-involved',
                       'grow-a-generation-audacious-robotocists',
                       'carnegie-library-of-pittsburgh-the-labs-at-clp---main---robotics-workshop-with-girls-of-steel',
                       'girls-of-steel-robotics-the-girls-of-steel-robotics',
                       'sarah-heinz-house-join-sharp',
                       'super-awesome-sylvia-watercolorbot',
                       'carnegie-mellon-robotics-academy-robots-virtual-world',
                       'robocup-manuela-veloso---robocup-champion'],
 'robots-101': ['carnegie-mellon-robotics-academy-expedition-atlantis-',
                'carnegie-mellon-university-rumbleblocks-',
                'carnegie-science-center-roboworld',
                'carnegie-library-of-pittsburgh-weekly-workshop-at-clp---allegheny',
                'walt-disney-animation-studios-big-hero-6',
                'christopher-atkeson-build-baymax',
                'synn-labs-music-video-with-rube-goldberg-',
                'carnegie-science-center-roboworld-activities',
                'assemble-summer-dreamers']}
chadwhitacre commented 8 years ago

@timothyfcook reports that 'sarah-heinz-house-join-sharp' is present in only one pathway in the spreadsheet. Maybe we cleaned that up but aren't seeing it and we should do https://github.com/saxifrage/caac-map/pull/71 after all?

chadwhitacre commented 8 years ago

Did a quick hack on #71 to get dag.py barely working, and now genmap seems to be running fine ...

chadwhitacre commented 8 years ago

This was due to duplicate data upstream, refreshing topics.json fixed it. I've added some checks for this condition. Will get a PR together for that and also for #71 next time.