search

saxifrage / cityasacampus

An open-source platform for connecting and showcasing resources within local learning communities.
http://cityasacampus.org/
5 stars 4 forks source link

Leverage Storage over Cookies for ngToken #370

Closed MatthewVita closed 8 years ago

MatthewVita commented 8 years ago

in PR here: https://github.com/saxifrage/cityasacampus/commit/e6cb103f4c97a1bcf2bba1a51287ddfba5d60c2f

MatthewVita commented 8 years ago

Still want to find out why library isn't sessionStorage. I'm going to try swapping out localStorage for sessionStorage and see what happens. Will then get in touch with the library authors with findings

dmtroyer commented 8 years ago

Still want to find out why library isn't sessionStorage

If I had to guess, I would say because they want the ability to control Token expiration beyond just one browser session. I believe the default is seven days on the rails gem.

MatthewVita commented 8 years ago

https://github.com/lynndylanhurley/ng-token-auth/issues/244

MatthewVita commented 8 years ago

^ that is the issue that I will work on in my spare time. We will use localStorage since I'm finding it makes more sense for our use case. closing

MatthewVita commented 8 years ago

:+1: for learning new things by experimentation and research!