logout functionality

[MatthewVita]

[MatthewVita]

@dmtroyer to do the code review

@cameronscott137 to review the above image to comment on where I placed the button and how it is styled (happy to make any changes)

[dmtroyer]

Code looks good to me!

!m @MatthewVita

[MatthewVita]

@dmtroyer yay. !m

Last check is @cameronscott137

[dmtroyer]

@timothyfcook may have an opinion regarding the styling

[timothyfcook]

A bit more padding inside the button. otherwise looks good!

[chadwhitacre]

I don't consistently get the logout button. For example, I don't get it when I hard-load the app on /#/dashboard.

[chadwhitacre]

But if I load / I get it.

But if I load /#/ I don't.

But if I load /#/ and then navigate to /#/explore, I do.

[dmtroyer]

I'm seeing the same behavior @whit537 mentions in https://github.com/saxifrage/cityasacampus/pull/371#issuecomment-162691668

[MatthewVita]

Okay all. I'll look into the bug and will change the logout design. Thanks

[MatthewVita]

found the issue: this line https://github.com/lynndylanhurley/ng-token-auth/blob/efe9660b31c348b05768fd9b35b23783a001c0cb/dist/ng-token-auth.js#L212 appears to be synchronous as it's just returning a boolean, but it's actually async because it calls the backend https://github.com/lynndylanhurley/ng-token-auth/blob/efe9660b31c348b05768fd9b35b23783a001c0cb/dist/ng-token-auth.js#L489

Not sure I like this; feels like a good candidate for returning a promise (will bring this up to the folks over at ng-token-auth repo to get their thoughts).

Regardless, I can sub on auth:validation-success and auth:validation-error to update the state for isAuthenticated method to return

bedtime ::zzz::

[MatthewVita]

UPDATE: I just added this commit https://github.com/saxifrage/cityasacampus/commit/8382565f96b5da9c1bd00ab40c0cdb03b624843e that fixes the isAuthenticated issue and applies the new styling.

@cameronscott137 2 things:

• I agreed with your statement about not nesting with SCSS/Stylus/LESS/etc because it can really make things confusing over time. 0 or 1 levels are plenty enough for me :) (I've used n levels where n could be 3-4 in the past and am reverting back)
• Please see my commit for the SCSS I used for the logout btn. I'm not happy about it because it's not very elegant. Any suggestions on making it better or do we have to accept that this "top area" is not a separate div so we have to "push" things up to it? Would it be worth it to throw another div up there or is that overkill?

@dmtroyer Please review my latest commit. Basically the $auth.userIsAuthenticated function from ng-token is not the correct approach. Calling $auth.validateUser (which returns a promise) is more appropriate as it will make a backend call on each hard page load and just check for a token in memory on each angular route change.

[chadwhitacre]

Good debugging, @MatthewVita! :bug:

[MatthewVita]

@whit537 :)

[MatthewVita]

all squashed up and ready to go