saxifrage / cityasacampus

An open-source platform for connecting and showcasing resources within local learning communities.

http://cityasacampus.org/

5 stars 4 forks source link

rough in an angularized organizers dashboard #380

Closed chadwhitacre closed 8 years ago

chadwhitacre commented 8 years ago

364 needs this for context.

chadwhitacre commented 8 years ago

Need to constrain the organizers listed for the user under /organizers.json to only those they have permissions on ...

dmtroyer commented 8 years ago

Need to constrain the organizers listed for the user under /organizers.json to only those they have permissions on ...

Are you talking rails API side @whit537?

If so, I have a use case where I am going to need the whole list of organizers as a public API. Could you put this at users/:id/organizers or sumpin?

chadwhitacre commented 8 years ago

Are you talking rails API side @whit537?

Yes! :-)

If so, I have a use case where I am going to need the whole list of organizers as a public API. Could you put this at users/:id/organizers or sumpin?

Sure thing! :-)

chadwhitacre commented 8 years ago

Roughed in in f2081b654c99e4b86382a3313f3151a84591b6f9, @dmtroyer. Now to constrain it ...

chadwhitacre commented 8 years ago

screen shot 2015-12-14 at 4 50 11 pm

chadwhitacre commented 8 years ago

Blam.

screen shot 2015-12-14 at 4 51 42 pm

chadwhitacre commented 8 years ago

A second user + organizer, demonstrating working constraint:

screen shot 2015-12-14 at 4 52 46 pm

chadwhitacre commented 8 years ago

screen shot 2015-12-14 at 4 55 51 pm

chadwhitacre commented 8 years ago

Do you think this PR needs to reproduce all of the functionality currently available in the rails dashboard?

chadwhitacre commented 8 years ago

On second thought, let's keep the scope tight on this PR. Marking ready for review, @dmtroyer @MatthewVita.

MatthewVita commented 8 years ago

Looks good to me

dmtroyer commented 8 years ago

The list of organizers at dashboard/organizers wasn't working for me when I was logged out of the rails-side dashboard. The organizers/for-current-user endpoint needed to be moved within the api/v1 scope to api/v1/organizers/for-current-user for ng-token-auth to attach the necessary headers so that the user could be authenticated that way (and current_user would work), instead of with the rails-side devise cookie like it was previously doing.

Eventually we should move all the routes within this scope.

@whit537 let me know if that makes sense and/or if you have any questions. To bed! :zzz:

chadwhitacre commented 8 years ago

Rebased on master. Previous head was c634a910c99abf059674a7b1533f970453442be5.

chadwhitacre commented 8 years ago

I'm gonna go ahead and squash this according to https://github.com/saxifrage/cityasacampus/issues/362#issuecomment-162029375 et seq.

chadwhitacre commented 8 years ago

Squashed. Previous head was 44098cf4c6499bb00450d2c0c1d72fb2c26e764f.

chadwhitacre commented 8 years ago

Resquashed. Previous head was 95e010b99a135d3035347fe3e17d42613ece8148.

chadwhitacre commented 8 years ago

I'm getting a 401 from organizers/for-current-user.json for anon. That's good.

screen shot 2015-12-21 at 10 23 45 am

chadwhitacre commented 8 years ago

Gonna stub out the buttons on the organizers dashboard:

screen shot 2015-12-21 at 10 28 00 am

chadwhitacre commented 8 years ago

Resquashed. Previous was 544033790e9b38138d5335a8cf9067d9be5c596c.

chadwhitacre commented 8 years ago

Alright, we ready to merge, @dmtroyer?

chadwhitacre commented 8 years ago

Ping @dmtroyer @MatthewVita ... ready for a review and merge over here ...

chadwhitacre commented 8 years ago

Thanks @dmtroyer. :)