search

sayanarijit / xplr

A hackable, minimal, fast TUI file explorer
https://xplr.dev
MIT License
4.08k stars 74 forks source link

Improve support for XDG on MacOS #630

Closed SolitudeSF closed 1 year ago

SolitudeSF commented 1 year ago

Im not familiar with rust, so its just an attempt to improve the situation.

sayanarijit commented 1 year ago

@noahmayr what do you think of it as a potential solution for https://github.com/sayanarijit/xplr/issues/627?

noahmayr commented 1 year ago

It does seem to work (on MacOS), tested both with and without XDG_CONFIG_HOME. However I feel like using the xdg-rust crate you suggested in #627 might be better to avoid platform specific logic in xplr.

Does xdg-rust cover all usecases where dirs is used for right now?

sayanarijit commented 1 year ago

Agree. Less platform specific code is preferable. Edit: But in this case, we might have to, so we don't break existing config.

sayanarijit commented 1 year ago

Merged https://github.com/sayanarijit/xplr/pull/631 since as per the doc, it shouldn't break existing config. Will re-open this pr if it does.