search

sayanarijit / xplr

A hackable, minimal, fast TUI file explorer
https://xplr.dev
MIT License
4.16k stars 74 forks source link

Illegal format character q #652

Closed duganchen closed 1 year ago

duganchen commented 1 year ago

I'm running XPLR in FISH, on my Mac, and when I "dD" to delete a directory, I see:

printf: illegal format character q

Permanently delete these files? [Y/n]:

My Mac has a /usr/bin/printf, and it's clearly what's being executed:

❯ /usr/bin/printf "%q", "aaa"
printf: illegal format character q

My Mac also has a /usr/bin/gls, which supports "%q", and yes, FISH has a built-in printf as well. But I think the expected behavior is for BASH's built-in printf to be used?

sayanarijit commented 1 year ago

Right... Bash should execute the command, even if your default shell is fish. Unless fish is named bash...

sayanarijit commented 1 year ago

And right, bash's built-in function should execute. Could be that bash is often outdated in mac? Will try it on a mac soon.

lcook commented 1 year ago

Please see #658, cheers. Note that xargs does not execute a shells builtin command, rather it looks for a binary in $PATH.