Es6

[simobasso]

move whole package to es6

[codecov-io]

Current coverage is 69.46% (diff: 69.46%)

No coverage report found for master at eda56e0.

Powered by Codecov. Last update eda56e0...ecdd2b2

[dennybiasiolli]

@simobasso can we also have an angular-pdf.js file in dist folder after building with webpack, like in the current master?

[rhyskoedijk]

Could I make a small suggestion since you are already writing this. Consider exposing the PDF.js _pdfDoc in the onLoad callback, which would allow end-users to provide their own hooks in to the document. I wanted to explore the adding "find text" functionality to my viewer but as Angular-PDF keeps the document internal, it is impossible to extend currently.

if (angular.isFunction(scope.onLoad)) { scope.onLoad(_pdfDoc); }

Maybe also a new callback at the start of the renderPage function to allow end-users to perform their own extra logic/rendering too?

[rhyskoedijk]

Can I fork simobasso:es6 and submit my own pull requests for this new version, or is that just making things overly complicated? I am interested in:

• Switching the canvasId to a canvasClassName. Class lookup rather than id looking works better when using multiple instances on the same page since you cannot generated unique canvas ids using angular bindings since the link function runs before any bindings in the template are resolved.
• Exposing pdfDoc in the onLoad callback as an extension point for end-users
• Exposing an onRender callback as an extension point for end-users

An issue I had around the pdfTask being cancelled when using multiple instances seems to be resolved in this version already as you have re-scoped the variables within the directive.

[dennybiasiolli]

Thanks for the feedback @rhyskoedijk, this speeds up our testing-before-merging process 😉

Our roadmap on the project is the following:

• merge this PR in order to provide a better structured project

• improve the project with the new features suggested

Starting from tomorrow we will fix conflicts in this PR in order to merge as soon as possible, so you can fork the master branch directly. Your suggestions are great, after PR's merge we will glad to focus our attention to them and if you would like to contribute with PRs we can improve this directive together 😄

Thanks for your help

[dennybiasiolli]

@simobasso what do you think about this branch? It resolves conflicts, fixes sintax errors and provide both standard and minimized output.

[rhyskoedijk]

just merge it ;)

[simobasso]

close in favor of #184