search

sayanee / angularjs-pdf

:page_facing_up: An AngularJS directive <ng-pdf> to display PDF files with PDFJS
http://sayan.ee/angularjs-pdf/
MIT License
494 stars 248 forks source link

Selectable text #183

Closed rorydpayne closed 7 years ago

rorydpayne commented 7 years ago

I know this issue has been opened and closed a couple of times, but I was trying to get text selection working yesterday. It was reasonably straight forward using getTextContent and by including the web/pdf_viewer.js and web/pdf_viewer.css from pdfjs.

Happy to tidy this up a bit and raise a PR if there's interest.

dennybiasiolli commented 7 years ago

Hi @rorydpayne, thanks for this issue, we are finishing the tests for PR #163 to modularize this directive. I know that including web/pdf_viewer.js and web/pdf_viewer.css it's possible to use PDFJS's extended features to show selectable text, we can implement this feature after PR is merged. We are glad to accept your help, what do you think about PR #163 ?

rorydpayne commented 7 years ago

Hi @dennybiasiolli . That's fine - I think the changes in #163 are a good move. I am happy to rework the selectable text functionality after #163 has been merged

dennybiasiolli commented 7 years ago

Thanks @rorydpayne, we are plannig a release within the beginning of the next week, stay tuned! ;)

rhyskoedijk commented 7 years ago

@rorydpayne I also started looking in to selectable text (and search/find) myself, great to see others are working towards this as well. Very keen to see #163 merged and the community functionality/PRs that follow it.

simobasso commented 7 years ago

@rorydpayne @rhyskoedijk #184 is merged! feel free to submit your PRs

NBE1 commented 7 years ago

@rorydpayne Any updates on your progress?