search

sayanee / angularjs-pdf

:page_facing_up: An AngularJS directive <ng-pdf> to display PDF files with PDFJS
http://sayan.ee/angularjs-pdf/
MIT License
494 stars 248 forks source link

Canvas Id #207

Open Paulsky opened 7 years ago

Paulsky commented 7 years ago

Hello,

I want to position the canvas element myself. I read in the Readme that I should use '<canvas id="x"></canvas>' in combination with <ng-pdf canvasid="x"></ng-pdf>.

But that’s not working. When I’m looking in the source code, I can see how the canvas is created: 'var canvas = $document[0].createElement('canvas');'.

But I can’t find anything in the code that checks for canvasid or if there is an existing canvas. Could you please help me? Or maybe update the readme?

mateoSerna commented 7 years ago

Same problem here

jegjessing commented 6 years ago

I too have this issue. Any solution for this soon? I'd like not to modify the source.

Should/could I modify the source and commit it here?

dennybiasiolli commented 6 years ago

Yes @jegjessing , you can modify the source, PR's are welcome!