sayedhajaj / RainDrop

raindrop game
1 stars 0 forks source link

An absolutely amazing game #23

Open samhstn opened 8 years ago

samhstn commented 8 years ago

It's truly amazing what you've managed to build and the code looks great too.

One minor issue is that double clicking in the game is quite common, but (in chrome at least) this prompts a full screen (and jumps in and out of full screen mode), I'm not sure this is desirable

I'd say (if possible) remove functionality to make the page a full screen or maybe have a separate full screen button

Btw, how have you been keeping are you still based in bethnal green?

You should pop around to Founders and Coders if your in the area, we can learn some javascript from you 😄

sayedhajaj commented 7 years ago

Hi Sam, Thanks for taking a look at the game and giving feedback. You're right about the full screen it does get annoying when on PC and I think having a button is a really good plan of action. I've disabled the fullscreen locally but I'll push it online after we get the button. I've been doing fine and have actually been thinking of going to a few more hackathons as the one we went to was a great experience for me and really opened up my eyes to how entrepreneurship and programming can be combined. I actually recommended Founders and Coders to a friend who suddenly decided he wanted to learn how to program and do it as a job.

I'd love to pop into Founders and Coders one day but maybe not teach javascript 😂

On 30 November 2016 at 23:54, Sam Houston notifications@github.com wrote:

It's truly amazing what you've managed to build and the code looks great too.

One minor issue is that double clicking in the game is quite common, but (in chrome at least) this prompts a full screen (and jumps in and out of full screen mode), I'm not sure this is desirable

I'd say (if possible) remove functionality to make the page a full screen or maybe have a separate full screen button

Btw, how have you been keeping are you still based in bethnal green?

You should pop around to Founders and Coders if your in the area, we can learn some javascript from you 😄

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/sayedhajaj/RainDrop/issues/23, or mute the thread https://github.com/notifications/unsubscribe-auth/ANMJOjriPpXm_Sm93ebOVehZZasPZUlGks5rDgzKgaJpZM4LA1pH .

-- Professor Sayed Hajaj

samhstn commented 7 years ago

That's really good to hear, give me a heads up for when your in the area, it would be great to catch up, also check your gitter, it's probably better to communicate there instead of in github issues.

gitter badge