sayedihashimi / package-web

Extensions for ASP.NET web projects package creation
32 stars 18 forks source link

Replace SedodreamPackageFolder property with PackageWebTargetsPath #65

Closed sayedihashimi closed 11 years ago

sayedihashimi commented 11 years ago

In the .wpp.targets file that is created the Import is added in the following way.

  <PropertyGroup Label="PackageWeb">
    <SedodreamPackageFolder Condition=" '$(SedodreamPackageFolder)'=='' ">$(MSBuildProjectDirectory)\_Package\</SedodreamPackageFolder>
  </PropertyGroup>
  <Import Project="$(SedodreamPackageFolder)Sedodream.Package.targets" Label="PackageWeb" Condition="Exists('$(SedodreamPackageFolder)Sedodream.Package.targets')" />

Pointing the path to a folder makes it a bit strange to override the path to the .targets path. Better would be

  <PropertyGroup Label="PackageWeb">
    <PackageWebTargetsPath Condition=" '$(PackageWebTargetsPath)'=='' ">$(MSBuildProjectDirectory)\_Package\</PackageWebTargetsPath>
  </PropertyGroup>
  <Import Project="$(PackageWebTargetsPath)" Label="PackageWeb" Condition="Exists('$(PackageWebTargetsPath)')" />