search

sayedihashimi / package-web

Extensions for ASP.NET web projects package creation
32 stars 18 forks source link

Add parameter to deploy to site root #74

Closed azurelogic closed 9 years ago

azurelogic commented 10 years ago

We found that we couldn't use package-web to deploy some of our projects as they were root of the web application. I added a parameter that switches deployment to the site root. The default value is false for backwards compatibility. Please let me know if any additional work is needed to get this pulled in.

Thanks!

Rob Ribeiro

sayedihashimi commented 9 years ago

@azurelogic did you close this due to the fact that I didn't review it for a while our another reason? If that's it I'm really sorry, I somehow missed this. If there is no other reason could you reopen and I'll make sure you change gets in. Really sorry about this. I've submitted PRs before that were ignored and I didn't appreciate it. I'm sorry I did the same to you.

azurelogic commented 9 years ago

@sayedihashimi, sorry for just closing it like that. I assumed that this project just wasn't receiving maintenance, and I didn't want to leave it hanging on the list. I'll be happy to reopen it. It has been a long time since I wrote this PR, and my memory is a little hazy about it. I do remember that the added parameter solved our issue with getting a site to deploy, but I later realized that my description of "deploying to site root" was misleading. Hopefully my changes will still make some sense. Thanks for responding too.

sayedihashimi commented 9 years ago

Thanks for re-opening the project is still active but I've been very busy with work/other OSS projects. I'm on vacation now but I'll get this in, sorry again.