Add CI build - Githubissues

sayedihashimi / package-web

Extensions for ASP.NET web projects package creation

32 stars 18 forks source link

Add CI build #77

Open sayedihashimi opened 9 years ago

sayedihashimi commented 9 years ago

We should add a CI build that produces the artifacts that are needed. Ideally if we merge to release it will publish to nuget.org as well.

[x] CI build, including artifacts in appveyor
[x] Update appveyor to publish nuget pkgs to the project/account feed
[ ] Update CI script to publish to nuget.org when building in the Release branch

seankearney commented 9 years ago

:+1: Nice move!

Now that there is an automated build, may I suggest using SemVer + GitVersion to auto version the NuGet package and the version in the script?

sayedihashimi commented 9 years ago

@seankearney can you be more specific?

seankearney commented 9 years ago

First, why not move towards using a simple SemVer versioning scheme? If moving to that isn't a problem then using a tool like GitVersion can help automate the versioning of the NuGet package.

The version number is hard coded in the Publish-Interactive file (currently reading 1.1.11.beta4). I'm not sure that is actually used so either remove that or automaticaly update that at build time.

Currently you have to update the .nuspec with the version number. The build script can leverage GitVersion to determine the version of the build. (i.e. 1.2.3 or 1.2.3.beta5) and automatically set the .nuspec.

seankearney commented 9 years ago

Take a look at Pull Request 78

seankearney commented 9 years ago

Regarding the last checkbox: AppVeyor is currently building all branches, correct? When it builds a non-master branch lets push the artifacts to the AppVeyor feed. When it builds the master branch lets push to the NuGet.org feed.

sayedihashimi commented 9 years ago

AppVeyor is currently building all branches, correct?

Correct

When it builds a non-master branch lets push the artifacts to the AppVeyor feed. When it builds the master branch lets push to the NuGet.org feed.

How about this, when we push to release branch (yet to be created) we release to nuget.org for all other branches we publish to AppVeyor feed? That way we can keep the latest and greatest in master and just merge to release when we want to go to nuget.org. If you feel strongly about your direction I'm ok with that as well. I just prefer to keep the latest code in the default branch in github.

~~@seankearney I will add you as a contributor.~~ Just noticed I already added you :)