Closed zabojad closed 1 year ago
Hi there @sayem314 ! Could you please have a look and eventually merge it?
Hi @zabojad! Apologies for the oversight and the delayed response. I will definitely take a look at the pull request and review it as soon as possible. Thank you for bringing it to my attention, and I appreciate your patience.
Hi @zabojad,
Thank you for the pull request and the code changes. I've reviewed the code and it looks good so far. However, before merging and publishing, I would like to ensure that the code has been tested on a real device. Could you please confirm if you have tested the changes on a real device?
Once we have confirmation of successful testing, I'll be more than happy to proceed with merging and publishing the changes.
Thank you!
Also can you please fix formatting here. https://github.com/zabojad/react-native-keep-awake/blob/2e7783a68802209a4f3dd4792c0e6248d7022d53/android/build.gradle#L7
And also remove Log.v*
from android/src/main/java/com/sayem/keepawake/KCKeepAwakeImpl.java
Thank you for the pull request and the code changes. I've reviewed the code and it looks good so far. However, before merging and publishing, I would like to ensure that the code has been tested on a real device. Could you please confirm if you have tested the changes on a real device?
Yes, I've tested on both iPhone and Android phone, and on both RN 68 and RN 71 with and without new architecture activated...
I've just pushed a new commit following your remarks...
Thank you very much. Much appreciated :)
Hi there !
Here is a PR adding support for the new architecture. It's still compatible with the old one though...
I've added a note to the README and bumped the package.json version to 1.2.0...