search

saymedia / angularjs-server

Specialized server for AngularJS sites
MIT License
247 stars 49 forks source link

Any plans to update to recent jsdom and nodejs? #31

Closed rjmackay closed 8 years ago

rjmackay commented 8 years ago

Are there any plans to update this module to more recent version of nodejs and jsdom?

thrashr888 commented 8 years ago

I've been looking at this myself but haven't had much time. We'd like to since this is blocking us from moving to Node v4+. We have a project downstream from this lib that we'd like to upgrade but we're okay with it not working with the latest version of this lib until we get to it.

We need to update the underlying angularcontext lib first, which it looks like you've sent a PR for (thanks!). Once that gets through we can upgrade this lib.

thrashr888 commented 8 years ago

angularcontext has been updated. I'm looking at upgrading the dependency now. It passes tests but I'd like to poke at it some more.

thrashr888 commented 8 years ago

Done!