Suffusion and PHP 7.3 - Githubissues

mbrsolution commented 5 years ago

Hi, I decided to test Suffusion with PHP 7.3 and WordPress 5.2. It works okay but with the following warnings. However I have not thoroughly tested all functionality of Suffusion yet.

Warning: "continue" targeting switch is equivalent to "break". Did you mean to use "continue 2"? in D:\webserver\xampp7-3\htdocs\mbrlocal\wp-content\themes\suffusion\functions\media.php on line 666

Warning: "continue" targeting switch is equivalent to "break". Did you mean to use "continue 2"? in D:\webserver\xampp7-3\htdocs\mbrlocal\wp-content\themes\suffusion\functions\media.php on line 671

Warning: "continue" targeting switch is equivalent to "break". Did you mean to use "continue 2"? in D:\webserver\xampp7-3\htdocs\mbrlocal\wp-content\themes\suffusion\functions\media.php on line 684

Warning: "continue" targeting switch is equivalent to "break". Did you mean to use "continue 2"? in D:\webserver\xampp7-3\htdocs\mbrlocal\wp-content\themes\suffusion\functions\media.php on line 689

Warning: "continue" targeting switch is equivalent to "break". Did you mean to use "continue 2"? in D:\webserver\xampp7-3\htdocs\mbrlocal\wp-content\themes\suffusion\functions\media.php on line 694

Kind regards

Ciprian-Dracea commented 5 years ago

Hi Manuel,

I committed all changes from past years in this repository and I corrected the media.php file to avoid these warnings. The new version of theme - 4.5.6. - can be downloaded from "dist" folder.

Please check the new version and close the issue if everything is OK.

Thank you for reporting, Drake

mbrsolution commented 5 years ago

Hi Drake,

Well done, your patch works well. That makes me very happy because it keeps the theme alive :)

I will keep doing more testing with PHP 7.3 and WordPress 5.2. I will report it here in a new support ticket if I find more issues.

Kind regards

sayontan / suffusion

Suffusion and PHP 7.3 #4