sayterdarkwynd / FrackinUniverse

1.4.4 SB release version of FrackinUniverse
Other
518 stars 360 forks source link

a pass at some elemental consistency #3579

Closed Kherae closed 4 months ago

Kherae commented 4 months ago

this PR is a big chunk of work, primarily addressing weapons that had incorrect elements or element tooltips assigned.

short notes: fixed many weapons' element icons and added several missing status effect listings on descriptions. made many weapons have proper elemental inheritance on alts, and fixed many weapons' elements. fixed an image error.

long notes:

buildfist.lua - added missing handling for element icons several fist weapon abilities were updated to inherit status effects and elemental type from the primary ability, but not all of them. similar was applied to staff, spear and scythe spin abilities. The above was also applied to the Screw Attack ability, which despite having elemental config defined in ability files never used them.

several melee weapons had their element type added so that they no longer did 'default' instead of their listed element. added missing status effect information to a number of melee weapons. Save The Queen now properly deals poison damage. It now also applies bee stings and poison to targets hit. Golden Honey Blade still deals physical damage, but applies burning and beestings on the normal hits (not the altfire however. but that deals fire damage.) Golden Sea Scion now deals poison damage and applies poison.

wildfire - now fires electric bullets instead of default damage. split bullets included. also, they all electrify. Pretty zappy when used on groups of enemies. graviton pistol - change element icon to cosmic phaser - final upgrade now updates description to list frostburn, element icon changes to cosmic energy lobber - now deals electric instead of poison

corrected hellfireprojectile images to have correct frames file dimensions and image dimensions, as they were causing errors. Corrected issues with fuflyingslash - lack of handling for physical element, and no check for whether a sound exists.