search

sayyam / carouselview

A simple library to add carousel view in android app.
Apache License 2.0
1.15k stars 260 forks source link

Continue changing views when the view is reattached #96

Closed appspell closed 6 years ago

appspell commented 6 years ago

Background it's a fix for the bug with reattached view. steps:

  1. add CarouselView to ViewHolder of RecycerView
  2. scroll the view out of the screen
  3. scroll back and see that autoPlay is stopped

The issue mentioned above you also (probably, haven't checked) you may see when you left the screen with ReceyclerView and went back.

Continue changing views when the view is reattached. This is a quick win. Ideally, I suggest:

  1. replace timers with handlers
  2. use LifecycleObservers to handle all lifecycle related cases