sayyid5416 / pyinstaller

Customisable GitHub Action to package python scripts into executables for different OS's
MIT License
44 stars 23 forks source link

--version-file option #28

Open andreabz opened 1 month ago

andreabz commented 1 month ago

Currently, --version-file is not listed in the pyinstaller options supported by this GitHub Action. Is this going to change?

sayyid5416 commented 1 month ago

@andreabz I'll need more info. Can you elaborate more about what you want!

andreabz commented 1 month ago

Sorry for being not clear, I'll try again! I'd like if your GitHub actions would support the pyinstaller --version-file option described here.

This option automatically includes the information provided in a predefined file, usually - or at least in my case - obtained by using pyinstaller-versionfile on a yml file, and makes them visible in the Windows property pane of the app.

I find this option useful to know in advance the name, description and version of the application I'm going to run, or to easily provide context for bugs reported by other users.

Thanks.

sayyid5416 commented 1 month ago

@andreabz Test with version-file branch, and report back if it's working or not.

uses: sayyid5416/pyinstaller@version-file
andreabz commented 1 month ago

@andreabz Test with version-file branch, and report back if it's working or not.

uses: sayyid5416/pyinstaller@version-file

Thanks. However, running this Action

` name: Python Pyinstaller

on: push: branches: [ "main" ] pull_request: branches: [ "main" ]

jobs: pyinstaller-build: runs-on: [ windows-latest ] steps:

Run python "D:\a\_actions\sayyid5416\pyinstaller\version-file/src/checks.py" Traceback (most recent call last): File "D:\a\_actions\sayyid5416\pyinstaller\version-file/src/checks.py", line 1, in <module> from actions import * File "D:\a\_actions\sayyid5416\pyinstaller\version-file\src\actions.py", line 2, in <module> from typing import Literal ImportError: cannot import name 'Literal'

Shouldn't be dependencies installed and included in the Action itself?

sayyid5416 commented 1 month ago

You are using python version 3.6, try to increase it

sayyid5416 commented 1 week ago

@andreabz Have this worked for you?