saz / puppet-php

Puppet module to manage php (Apache, CLI, FPM)
Other
64 stars 38 forks source link

Update manifests/module.pp #6

Closed guilhermeblanco closed 12 years ago

guilhermeblanco commented 12 years ago

Remove obscurity of $source declaration for modules. We can surely add the previous behavior as an append if needed, but I found myself forced to read the source code to understand how it works. Also, this code is incompatible with possibilities, like multiple folder/file choices, so I consider that this native "feature" should be removed. Here is my example use case:

php::module { 'php-apc':
    name           => 'apc',
    package_prefix => 'php-',
    notify         => Class['php::fpm::service'],
    source         => [
        "puppet:///modules/project/php/conf.d/apc.${env}.ini",
        "puppet:///modules/project/php/conf.d/apc.ini",
    ],
}
guilhermeblanco commented 12 years ago

Relates to #4

saz commented 12 years ago

Thanks. I'll refactor this module soon as I'm not satisfied with the current module state.