search

saz / puppet-sudo

Manage sudo with Puppet on Debian-, RedHat- and SUSE-based linux distributions and some BSDs
Other
105 stars 215 forks source link

Sudo configs take a wrong default config_dir variable #143

Closed endzone closed 8 years ago

endzone commented 8 years ago

During class definition one can change the config_dir variable, like so:

class { '::sudo':
    config_dir => '/etc/sudoers.puppet',
}

But this change is neglected by actual sudo config, because they use the OS default sudo::params::config_dir instead of the class sudo::config_dir (which defaults to sudo::params::config_dir but can be overridden), see: https://github.com/saz/puppet-sudo/blob/master/manifests/conf.pp#L55

  $sudo_config_dir_real = $sudo_config_dir ? {
    undef            => $sudo::params::config_dir,
    $sudo_config_dir => $sudo_config_dir
  }

This needs to be changed to 

  $sudo_config_dir_real = $sudo_config_dir ? {
    undef            => $sudo::config_dir,
    $sudo_config_dir => $sudo_config_dir
  }

If needed, I will provide pull request with a fix shortly