search

saz / puppet-sudo

Manage sudo with Puppet on Debian-, RedHat- and SUSE-based linux distributions and some BSDs
Other
105 stars 215 forks source link

sudoversion is less os-specific, add tests #153

Closed jyaworski closed 7 years ago

saz commented 8 years ago

What if sudo isn't installed? This fact is used inside the module on RedHat only and will try rpm querying first.

jyaworski commented 8 years ago

A couple of options are available, then. In https://github.com/voxpupuli/puppet-collectd we made a minimum_version parameter to get around the 'needs two runs to configure' problem. We could look at the matrix that this module supports, and return the oldest version in the matrix. Then it would populate on first run.

Although this isn't necessarily an argument, "sudo" not being installed is very rare these days.

jyaworski commented 8 years ago

Another alternative is that if it returns blank or isn't installed somehow, we could then use rpm or dpkg.

saz commented 8 years ago

@jyaworski I like your suggestion. Querying the package manager in the fact is one way to avoid the requirement of multiple runs, as you will have a version.

@tosmi Do you know, if the warning inside sudo::conf is still required?

jyaworski commented 8 years ago

@saz done.

jyaworski commented 8 years ago

Ping @saz

saz commented 8 years ago

Is there a reason for closing this?

jyaworski commented 8 years ago

It was unmerged for some time.