search

saz / puppet-sudo

Manage sudo with Puppet on Debian-, RedHat- and SUSE-based linux distributions and some BSDs
Other
107 stars 215 forks source link

configure env_keep SSH_AUTH_SOCK by default in ubuntu/debian #229

Closed ixpict closed 1 month ago

ixpict commented 5 years ago

It's very useful options, let's keep it on by default?

saz commented 5 years ago

@ixpict Have you checked, if this is a default value on Debian based systems?

baurmatt commented 5 years ago

I've checked Ubuntu 14.04/16.04/18.04: Its not included by default.

I would suggest to not merge this as it might lead to security problems.

A good alternative would probably be to make the "Defaults" configurable so everyone can configure sudo for their usage.

ixpict commented 5 years ago

It's not a default option, but very useful.

@baurmatt you mean something like presets?

saz commented 5 years ago

@baurmatt Same thoughts.

@ixpict I'll see if I'll have the time to come up with a better solution, but I don't think, I'll be able to get this worked out before the next release

saz commented 5 years ago

Please leave this PR open as a reminder for me :-)

ixpict commented 5 years ago

ok :)

saz commented 1 month ago

The Defaults are now configurable in master. I'll make a new release asap, but this PR isn't needed anymore.