saz / puppet-sudo

Manage sudo with Puppet on Debian-, RedHat- and SUSE-based linux distributions and some BSDs
Other
107 stars 215 forks source link

Don't show errors on Windows with "sudo" #259

Closed jovandeginste closed 3 years ago

jovandeginste commented 3 years ago

You might have an executable called "sudo" installed on your Windows machine (eg.: http://blog.lukesampson.com/sudo-for-windows)

This executable would probably not behave similar to the Linux version, which makes it irrelevant for this Puppet module.

However, while you wouldn't load the sudo manifest on a Windows machine, the facts may still be parsed (eg. if you share your Puppet tree between Linux and Windows desktops), which then might throw an error.

This will override the sudoversion to be nil on Windows machines, and as such get rid of this error. This does not imply any actual support for the Windows family of OS'es.

Fixes: #258

jovandeginste commented 3 years ago

Are CI failures to be expected? They seem unrelated to my changes...