saz / puppet-sudo

Manage sudo with Puppet on Debian-, RedHat- and SUSE-based linux distributions and some BSDs
Other
107 stars 215 forks source link

sudo::content parameter is poorly named #272

Closed jhoblitt closed 1 year ago

jhoblitt commented 2 years ago

The general expectation is that one would be able to pass a string of content similar to the semantics of the file::content parameter. However, in this case it wants the name of a template and there is no way to pass in the content of /etc/sudoers as a string.

saz commented 2 years ago

As I'm aware of a couple of modules, I'm usually not assuming something :-)

Anyways, we might just move the template() part to the class parameter. This way, it's possible to pass in a string. It's still a breaking change, but I have the feeling, that it's affecting less people.

What do you think?

danpoltawski commented 2 years ago

Agree that it would be better to pass in a string - I would like to evaluate my own template with my own variables and the current behaviour does not allow this to work.