search

saz / puppet-sudo

Manage sudo with Puppet on Debian-, RedHat- and SUSE-based linux distributions and some BSDs
Other
105 stars 216 forks source link

RHEL Sudo config file breaks sudo if package < 1.7.0 #30

Closed fatmcgav closed 10 years ago

fatmcgav commented 11 years ago

As defined here, sudo > 1.7.0 introduced some new config values, which aren't supported < 1.7.0.

This results in the sudo config being broken on a stock Centos 5 install, which uses sudo-1.6.8p12-12.el5.

Initial thought is to have a different config file for RHEL5 vs RHEL6, as RHEL6 ships with sudo-1.7.4p5-13.el6_3.x86_64 so supports the new values...

tosmi commented 11 years ago

the problem is, as far as i know, sudo < 1.7.0 does not support the #includedir directive. so this module will not work with sudo < 1.7.0. i've fixed this issue in my local fork which i will push asap.

tosmi commented 11 years ago

i forgot to mention that with rhel 5.5. there's a new version of sudo (1.7.2). so you should set autoupgrade to true. the next problem is that the default sudo config does not have #includedir. so either you set config_replace to true (which does not work well if there are existing entries...) or you use augeas to add #includedir. my fork is going to include the augeas part.

fatmcgav commented 11 years ago

@tosmi Yeh, I hit the same issue with includedir not being supported, so I switched to using autoupgrade to move all EL5 servers to use Sudo > 1.7.

So from my point of view, happy for this one to be closed. Unless u want to support Sudo < 1.7 aswell...

Cheers Gav