search

saz / puppet-sudo

Manage sudo with Puppet on Debian-, RedHat- and SUSE-based linux distributions and some BSDs
Other
105 stars 215 forks source link

Changing sudoers to reflect the actual default #65

Closed ggeldenhuis closed 10 years ago

ggeldenhuis commented 10 years ago

The expectation is that the default file will match the OS default. This is extracted directly from the RHEL 5.10 sudo-1.7.2p1-28.el5.x86_64.rpm

ggeldenhuis commented 10 years ago

Having been reprimanded by a colleague for a to terse a commit message I am attempting to rectify this.

The expectation is that the default file for a platform will match what you get by just installing the sudo rpm. In the case of rhel5 this seems to be not the case and a large amount of lines were uncommented which is commented by default in the sudoers file provided by the sudo rpm. That being said I have only compared this against the latest rpm available in rhel 5.10 and not any of the other potential rpm versions.

saz commented 10 years ago

@tosmi any opinion on this PR? You've more experience with RedHat :)

tosmi commented 10 years ago

looks good to me. maybe the only thing we should keep in the template is the #includedir directive. We add #includedir with augeas on the first puppet run, but why not deploy a template that works out of the box.

saz commented 10 years ago

@gjngeldenhuis Can you change the template as mentioned, please?

ggeldenhuis commented 10 years ago

@saz will do so a bit later today and submit pull request.

saz commented 10 years ago

Awesome. Thank you!