Bug on sequential data - Githubissues

sb-ai-lab / LightAutoML

Fast and customizable framework for automatic ML model creation (AutoML)

https://developers.sber.ru/portal/products/lightautoml

Apache License 2.0

1.08k stars 47 forks source link

Bug on sequential data #124

Closed susie-ku closed 10 months ago

susie-ku commented 10 months ago

Wrong logic in conditions Correct both for numeric and categoric features cat: https://github.com/sb-ai-lab/LightAutoML/blob/0bcbb8523b499e27eea493eca1d44b247b42e4b0/lightautoml/ml_algo/dl_model.py#L316C22-L316C22 cont: https://github.com/sb-ai-lab/LightAutoML/blob/0bcbb8523b499e27eea493eca1d44b247b42e4b0/lightautoml/ml_algo/dl_model.py#L303

To reproduce: for Autoint and FTTransformer set use_cat to False, advanced_roles to False and all features to numeric

susie-ku commented 10 months ago

Add missing default embedders to seq embedders https://github.com/sb-ai-lab/LightAutoML/blob/0bcbb8523b499e27eea493eca1d44b247b42e4b0/lightautoml/ml_algo/dl_model.py#L113

D1MK4real commented 10 months ago

Done.