search

sb-ai-lab / Py-Boost

Python based GBDT implementation on GPU. Efficient multioutput (multiclass/multilabel/multitask) training
Apache License 2.0
157 stars 13 forks source link

TopK sketching method ignores sketch_params kwargs #13

Closed davidfstein closed 1 year ago

davidfstein commented 1 year ago

In sketch_boost.py

 elif sketch_method == 'topk':
            sketch = TopOutputsSketch(sketch_outputs)

should be

 elif sketch_method == 'topk':
            sketch = TopOutputsSketch(sketch_outputs, **sketch_params)
davidfstein commented 1 year ago

Nvm, I see now that sketch_outputs corresponds to the k parameter so there is no need for sketch_params