search

sb12 / OSMTrainRouteAnalysis

Analysis of Train Routes Based on OpenStreetMap Data
Other
14 stars 6 forks source link

Better error handling for setting train default #101

Open ghost opened 9 years ago

ghost commented 9 years ago

Provide human readable error message when updating the database for default train faults.

sb12 commented 9 years ago

Could you please explain in more detail what you mean? Do you mean the "Can't set as default" message when trying to set an incompatible train as default or do you want to see an error message when updating the mysql database fails? Or do you mean something else?

ghost commented 9 years ago

Yes I mean "Can't set as default". Why is a train incompatible?

sb12 commented 9 years ago

Why is a train incompatible?

If a route is defined as a high-speed train service in the OSM database, it's rather unlikely that the train serving the route in reality is e.g. a regional train or a tram. Therefore it is not allowed to set it as the default train. You can still choose the regional train for the route, it is just not allowed to set it as the default train. The same happens for other unlikely combinations. The default train is the one saved to the database and the one which is shown on the front page and will be selected when opening a route from the list.

ghost commented 9 years ago

I wanted to change the default train of 1998580 to a valley duck as it is in reality. It even is not electrified so an electric tram is nonsense.

sb12 commented 9 years ago

Changing the default train should be possible again, now. I leave this open, as it might still be a good idea to show an error when something is wrong with the database and a more descriptive message when trains are incompatible with the route.