search

sb2bg / CustomDeathMessages

CustomDeathMessages from spigot
https://www.spigotmc.org/resources/customdeathmessages-cdm.69605/
14 stars 6 forks source link

Hook into DiscordSRV #22

Open Etanarvazac opened 12 months ago

Etanarvazac commented 12 months ago

DiscordSRV[^1] listens specifically to the message itself. Upon adding this plugin, DiscordSRV sends [UNCATEGORIZED DEBUG] Not sending death message for <player>, death message is null to the console (whilst debug is on). Even though the message is simply re-written according to this plugin. Could a hook be made for DiscordSRV's death listener[^2]?

Click here DiscordSRV's hook directory.

[^1]: DiscordSRV GitHub: https://github.com/DiscordSRV/DiscordSRV [^2]: Death Listener file: https://github.com/DiscordSRV/DiscordSRV/blob/master/src/main/java/github/scarsz/discordsrv/listeners/PlayerDeathListener.java

sb2bg commented 11 months ago

The message is not simply rewritten, depending on certain settings, it's more complex. I've looked into it, but their API is poor and will be added when I can figure out the easiest way. EssentialsDiscord has already been implemented on the development branch, and I would like to get DiscordSRV as well before pushing this next update. Thanks!

v4rl1 commented 7 months ago

Hello, first of all thanks for the awesome plug-in you made ! After trying out diffenret ones, this is clearly the best available.

I also came here to ask the same thing of you, and I was wondering if you were able to figure out a solution ?

If that can be of help, I've seen that AxKills (https://www.spigotmc.org/resources/axkills-customizable-kill-messages.112119/) manages to hook into DiscordSRV, because I tried it before your plug-in.

v4rl1 commented 5 months ago

Hello, just figured another way that could be done which would be simpler on your end I think perhaps.

If you had an API that contained Events it could be read by the alerts feature DiscordSRV already had, and wouldn't need for you to hook into their API

Etanarvazac commented 5 months ago

Hello, just figured another way that could be done which would be simpler on your end I think perhaps.

If you had an API that contained Events it could be read by the alerts feature DiscordSRV already had, and wouldn't need for you to hook into their API

That could be possible. I do apologize for the [very] late reply. Been busy with other things...