sb2g14 / soton_3D_print

3 stars 0 forks source link

Check database before release #102

Closed GHLasse closed 6 years ago

GHLasse commented 6 years ago

A couple of things I would like you to remember to check before releasing the new version:

Please let me know when you are ready to push, Please don't push before Thursday, so we can give Tim and Katherine time to check the cost codes which have expired. Also, I am happy to help looking at the printing history with you.

sb2g14 commented 6 years ago

printer 15: Status available but has unresolved issue printer 26: Unresolved issue shown as resolved in the history printer 31: The printer status is missing, issue opened but there are successful prints after

GHLasse commented 6 years ago

printer 15: Is it enough to just change the status to "broken"? if there are no more prints done on it since, then assume it is broken, and let people resolve the issue if they think it's fine. printer 26: if there is no date closing the issue in the database, then it's an error in php - would need to look at the code with you. printer 31: yeah, that's a bit messed up. I wonder how an Up BOX went missing... I think those prints are for printer 32. The printer is missing, so no one can print anymore now (not even demonstrators).

I have a suggestion how to deal with scenarios like with Printer 31: changing the status on the printer from broken to missing doesn't add a comment but creates a new issue. In that case we have two open issues for a printer: the printer is broken AND it is missing. They can then be resolved individually. We do need to make sure that resolving an issue checks for other open issues to update the status. -> I think I will create a new issue for this and we can discuss the details there.

GHLasse commented 6 years ago

I think we did the best we could on this one :-) Will ignore the order (at least for now)