search

sb2nov / mac-setup

Installing Development environment on macOS
https://sourabhbajaj.com/mac-setup/
Other
7.15k stars 1.02k forks source link

add step that makes usage of global file ~/.gitignore complete #235

Closed barmanrajdeep closed 5 years ago

barmanrajdeep commented 5 years ago

Tool: Git Installation Usage Customization More

simeg commented 5 years ago

@Kyslik Sounds good to me! A nice description at the start of the section is always useful too. I can add that outside of this PR though.

simeg commented 5 years ago

@Kyslik so what do we do here? You said "We can change it in this PR" but what does that mean? Do we change it, do we ask the author to change it? :)

Kyslik commented 5 years ago

I guess we can merge the PR and just make a new one with my suggestion :)

And yea, I wanted to engage author to change it.

In the end it does not really matter.

Best, Martin Kiesel

On Dec 26, 2018, at 5:32 PM, Simon Egersand notifications@github.com wrote:

@Kyslik so what do we do here? You said "We can change it in this PR" but what does that mean? Do we change it, do we ask the author to change it? :)

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub, or mute the thread.

simeg commented 5 years ago

@Kyslik 👍

I like the idea of merging PRs and later fixing minor things ourselves! That way there's less work for the contributor which could result in more PRs => better guide 😄