sb2nov / mac-setup

Installing Development environment on macOS
https://sourabhbajaj.com/mac-setup/
Other
7.15k stars 1.02k forks source link

Add sudoers permission instruction to system preferences #237

Closed worldofprasanna closed 5 years ago

worldofprasanna commented 5 years ago

fixes #236

simeg commented 5 years ago

How I see it is that the sudo command is there for a reason, by disabling it you're potentially opening up for security issues with your user. What if someone gets access to your system? Then they'd have super user permission.

I like this approach more:

@Kyslik: [..] Perhaps better way is to increase sudo timeout or maybe use -1 for the timeout; so current shell does need sudo password only once.

I don't like recommending major security risks in a guide aimed at the average Joe.

@worldofprasanna Maybe we can phrase this differently? Instead of giving permanent super user access we could explain how to increase the timeout (what @Kyslik said), but also mention the risks with it. What do you think?

worldofprasanna commented 5 years ago

@simeg @Kyslik - Yes. I haven t thought about this point before. Might be I will rephrase it and mention the potential issue it can lead to. Also will mention the alternate approach.

Thanks for your thoughts 👍

simeg commented 5 years ago

@worldofprasanna I'm sorry if I wasn't clear enough - I don't think we should include giving permanent sudo access at all. Instead I think we only should include the approach where we give sudo access temporarily. I consider permanent sudo access really bad practice and I don't think we should encourage it.

The system admins around the world who might actually need this are well aware of it, the average developer does not need to know about it. My 2 cents..

What I recommend is:

hugovk commented 5 years ago

I agree with @simeg.

Even increasing the timeout reduces the security. And if you need sudo a lot, maybe there's a better way of doing things.

worldofprasanna commented 5 years ago

@simeg I got your point about security concern in using this solution in some server. I had rephrased the approach to edit the sudoers file.

@hugovk I am always using this approach to avoid giving password everytime. What are the other ways to do this ? Please let me know.

simeg commented 5 years ago

@worldofprasanna Thinking about this some more and reading your changes I'm not sure if I think this information belongs in this guide. From what I know this isn't a common issue, having to type your password in when doing sudo, so keeping it in this guide which is targeted for developers setting up their new machine (or new tool etc.) doesn't feel right. It's more of a system administrator thing, I feel like.

We always appreciate contributions but they have to fit the purpose of the guide. I'm sorry but I have to vote for this to not be merged.

worldofprasanna commented 5 years ago

@simeg Yes. No probs. Thanks again for lot of info. Please feel free to close the pull request.