Upgrade linter version - Githubissues

sb2nov / mac-setup

Installing Development environment on macOS

https://sourabhbajaj.com/mac-setup/

Other

7.15k stars 1.02k forks source link

Upgrade linter version #293

Closed simeg closed 4 years ago

simeg commented 4 years ago

Upgrade linter version
Fix linting errors that came with new version
Give error message if linter not installed

hugovk commented 4 years ago

Will the CI fail if it finds lint problems in future PRs?

If so, do you know why it hasn't complained about these before?

simeg commented 4 years ago

@hugovk It's already running on CI, and it fails on errors 🙂 With the new linter version came new errors.

It's easy to run the linter locally, just make deps to install dependencies (the linter included) and make lint to run the linter.

simeg commented 4 years ago

@kamleshkc2002 Thanks for taking a look! I'd like to get this merged and someone can make the changes you proposed in a different PR, what do you think?

kamleshkc2002 commented 4 years ago

sounds good.. these are minor changes.. i will take this up as a separate pr outside this. approving this