search

sb2nov / mac-setup

Installing Development environment on macOS
https://sourabhbajaj.com/mac-setup/
Other
7.15k stars 1.02k forks source link

Remove Python dependency for deploying #294

Closed simeg closed 4 years ago

simeg commented 4 years ago

The python script required a virtualenv to have all of its dependencies, or have them installed globally on your machine. Since we're already installing dependencies using npm/yarn I figured we can just add one more dependency and not have to worry about Python.

I've tested the new script and it outputs the exact same content as the python script.

Let me know what you think!

apjanke commented 4 years ago

Personally, I dig it. Yay to fewer dependencies.

simeg commented 4 years ago

I seem to have broken the build with my previous PR. I'll look into it tomorrow.

kamleshkc2002 commented 4 years ago

the build failure looks like it needs a regeneration of the lock file.

kamleshkc2002 commented 4 years ago

can you let me know how to reproduce this issue on my local? i wanna give a shot at fixing this.

simeg commented 4 years ago

I can't reproduce locally :/ Even when running the same version of node (14). I think I want to revert the broken PR so we can deal with that outside this PR.

simeg commented 4 years ago

I upgraded to Node 14.5.0 and now I can reproduce it by running make ci. Will try fixing it in https://github.com/sb2nov/mac-setup/pull/297.