sb2nov / mac-setup

Installing Development environment on macOS
https://sourabhbajaj.com/mac-setup/
Other
7.18k stars 1.02k forks source link

Use urlsup to health check #295

Closed simeg closed 4 years ago

simeg commented 4 years ago

I've written urlsup over the last few months. It's more robust and faster than the bash script. I wrote it to be used for this repo specifically, but can of course be used for any similar type of repo.

The downsides to using this tool over the script are

I do however feel that I'd like to try it, do some dogfooding to have it run on an actual project.

Let me know what you think!

simeg commented 4 years ago

Hmm it looks like it's not faster actually because it needs to download the image. Caching a single small image doesn't seem like a good approach.

So we don't get any speed gains but it's a daily cron job so it doesn't matter.

It currently is using the links from the health-check branch. I need to point it to the master branch.

simeg commented 4 years ago

Now it runs on master branch. It already found two issues (yay) that I fixed.

@hugovk Could I get an approval so I can merge this? 🙂