search

sb2nov / mac-setup

Installing Development environment on macOS
https://sourabhbajaj.com/mac-setup/
Other
7.15k stars 1.02k forks source link

Mistake in Java section #314

Open Rover1176 opened 3 years ago

Rover1176 commented 3 years ago

I'm Submitting a ...

[x] Bug report
[ ] Tool/language/etc documentation request

Bug Location

In the Java section, there seems to be a mistake. There are actually 2 variants of OpenJDK(Oracle's OpenJDK and AdoptOpenJDK). https://openjdk.java.net/ https://adoptopenjdk.net/

The first install method mentioned in the guide using terminal actually installs the 1st version. And the 2nd manual method installs the 2nd version. To install the 2nd version using terminal, the command is 'brew install adoptopenjdk' Do make that change.

apjanke commented 3 years ago

I think this is a good idea. Note that AdoptOpenJDK is in a "cask", so the command to install it (which should work for all users) is: brew cask install adoptopenjdk. I think plain brew install adoptopenjdk will give you an error.

Rover1176 commented 3 years ago

I can't see how i missed that typo. I had typed the command correctly when installing it on my mac XD.