search

sba1 / ontologizer

Ontologizer is a tool for identifying enriched Gene Ontology terms in lists of names of genes or gene products.
http://ontologizer.de
8 stars 8 forks source link

Disable Doclint for Java8 (for now?) #3

Closed moriarty closed 8 years ago

moriarty commented 8 years ago

mvn package failed. Google found this:

http://blog.joda.org/2014/02/turning-off-doclint-in-jdk-8-javadoc.html

Better alternative is updating the javadocs which fail. Which is why I added "for now".

I haven't tested if this is backwards compatible with older versions of Java.

moriarty commented 8 years ago

FYI, system & java info.

$ mvn -V
Apache Maven 3.0.5
Maven home: /usr/share/maven
Java version: 1.8.0_91, vendor: Oracle Corporation
Java home: /usr/lib/jvm/java-8-oracle/jre
Default locale: en_CA, platform encoding: UTF-8
OS name: "linux", version: "4.4.0-22-generic", arch: "amd64", family: "unix"
sba1 commented 8 years ago

Thanks for the contribution.

I cannot reproduce the problem and I'm using Java8, but I have also a Java 7 installation. Perhaps, this have precedence over the Java 8 one (though the mvn reports Java 8 and javadoc is also the proper one by default).

It would also indeed break Java 7 builds. So we have to use profiles or other means until the problems are fixed.

I enabled also building against JDK8 in travis. Let's see what comes out of this.

moriarty commented 8 years ago

:+1:

sba1 commented 8 years ago

I fixed all errors, there are still warnings but the build passes according to Travis. The change to switch off the Javadoc linter is IMO no longer necessary. Thanks for initiating this.

moriarty commented 8 years ago

Great :+1 fixing the issues is better than turning off javadoc