Fix incorrect version of puppet being installed in tests

sbadia / puppet-gitlab

Puppet module for manage GitLab installation

http://forge.puppetlabs.com/sbadia/gitlab

GNU General Public License v3.0

131 stars 76 forks source link

Fix incorrect version of puppet being installed in tests #113

Closed lboynton closed 10 years ago

lboynton commented 10 years ago

I noticed the latest version of puppet was always being used in the travis builds due to mismatching environment variables in the Gemfile and .travis.yml. I've updated the Gemfile to use the PUPPET_GEM_VERSION env so that it matches .travis.yml.

lboynton commented 10 years ago

Unfortunately this does seem to cause failures with puppet 3.0.2, but I believe that to be unrelated to this change.

sbadia commented 10 years ago

Oh ! Nice shot @lboynton Indeed… :-D (a bit useless…) Thank you !

sbadia commented 10 years ago

@lboynton, yep, no problems ;-) (it's related to rspec-puppet, a well know issue), I'll fix the matrix right now. Thanks !

lboynton commented 10 years ago

The reason I came across this actually was because I am trying to work out why my specs fail on puppet 3.0.x in my module: lboynton/puppet-ejabberd#1. Do you think it's an rspec-puppet issue too?

sbadia commented 10 years ago

@lboynton yes ! We've the problem some week ago in puppet OpenStack modules (see: https://review.openstack.org/#/c/65406/ ) And for explanation:

https://groups.google.com/a/puppetlabs.com/forum/#!topic/puppet-openstack/XTjeaVQu9GY

lboynton commented 10 years ago

OK, thanks @sbadia! I had come across that bug in puppet from Googling, but wasn't sure if it was indeed the cause of my problem. I think I'll remove puppet 3.0 from the builds.