search

sbadia / puppet-gitlab

Puppet module for manage GitLab installation
http://forge.puppetlabs.com/sbadia/gitlab
GNU General Public License v3.0
131 stars 76 forks source link

Installation fails if nginx is absent #121

Open xaniasd opened 10 years ago

xaniasd commented 10 years ago

Hi, I want to install GitLab with Apache, however the following resource breaks the installation if nginx is not present in the system. 

 # gitlab
  file { '/etc/nginx/conf.d/gitlab.conf':
    ensure => file,
    content => template('gitlab/nginx-gitlab.conf.erb'),
    owner => root,
    group => root,
    mode => '0644',
  }

Removing it resolves the issue so if you want to allow the option of using Apache instead of nginx, you might want to consider making this optional.

Cheers

igalic commented 10 years ago

We are considering these things, see #102 & #111.

xaniasd commented 10 years ago

I've seen those issues, but no conclusive decision yet. I guess my point is that this one is an easy fix ;-)

keep up the good work!

atomaka commented 10 years ago

Unfortunately, it's an easy fix that breaks current installations that rely on a configured nginx. Anything that breaks current functionality needs to be given serious consideration. Good to confirm that it is only one resource causing an issue though.

One of the slow points here is that we would likely need to add Passenger support along with Apache support adding a bit more complexity to the problem. Are you using Passenger or Unicorn for your application server, @xaniasd?

xaniasd commented 10 years ago

I see. How about making it optional but defaulting to run unless explicitly configured not to?

I'm using Unicorn. If there's something I can check for you with my set-up, let me know.

lmello commented 10 years ago

my suggestion would be to have a switch like gitlab_webserver => nginx|apache then people could choose which webserver to use, and we would have a if test to supply the correct config file for the correct webserver. this would require some refactoring of spec tests. and that the default behaviour be to install the nginx file.

sammcj commented 10 years ago

May I asked why you'd want to use it with Apache over Nginx? Nginx is significantly faster and easier to configure.

igalic commented 10 years ago

i'm not sure the latter really makes a difference with puppet ;)

(and with my apache software foundation hat on: i disagree that nginx is faster ;)