search

sbadia / puppet-gitlab

Puppet module for manage GitLab installation
http://forge.puppetlabs.com/sbadia/gitlab
GNU General Public License v3.0
131 stars 76 forks source link

Upgrade to GitLab 6.7 #132

Closed sbadia closed 10 years ago

sbadia commented 10 years ago

Gitlab changelog

Todo:

Tested in my sandbox (functional testing), and unit-test

atomaka commented 10 years ago

bundle && rake failed two tests from the new usage of and_raise_error. This must have been introduced in #141. Tests pass on TravisCI so it's a local issue (even though I can replicate in Ubuntu 12.04, 13.04 and OSX). Any thoughts, @sbadia?

Vagrant run / functional testing in progress.

atomaka commented 10 years ago

Looks good functionally and passing tests on Travis! Any thoughts on my test issues would still be appreciated though.

sbadia commented 10 years ago

@atomaka, thanks! Hum for and_raise_error you have the latest version of rspec-puppet ? (0.1.6), in our gemfile we use the living GIT master branch. (This change was introduced ±2months ago, https://github.com/rodjek/rspec-puppet/commit/af16914a631ad363fdfe115de394734d434f9579) We fall back to a stable version of rspec-puppet?

atomaka commented 10 years ago

My mistake. Running with bundle exec worked. Must have lost my rbenv-bundler. Everything's good locally!