search

sbadia / puppet-gitlab

Puppet module for manage GitLab installation
http://forge.puppetlabs.com/sbadia/gitlab
GNU General Public License v3.0
131 stars 76 forks source link

Added support for company link and logo #160

Closed ghost closed 10 years ago

ghost commented 10 years ago

This commit adds the possibility to show a logo and a link under the sign-in page. The content is based on the suggestion commented from gitlab in templates/gitlab.yml.erb:264.

sbadia commented 10 years ago

thanks @lschoepps, but with a rspec test it would be perfect =)

ghost commented 10 years ago

I've made some rspec tests. I don't know if it is the correct way to do them since it affects multiple lines. I didn't write tests if only some options are specified and not the three together. Should I do so ?

sbadia commented 10 years ago

hi, hum we could maybe remove the meta-char (like \t and \n in order to not break the tests if a wite-space is changed =)) but ok. Thanks!!

ghost commented 10 years ago

You're right, I can commit this change if you want (the removal of '\n').

sbadia commented 10 years ago

As you want, but it's not really a big problem ;)