The gitlab module is no longer idempotent

[blkperl]

Due to https://github.com/alup/puppet-rbenv/issues/80 the rbenv module always triggers an event. There is a proposed patch https://github.com/alup/puppet-rbenv/pull/97 but there has been no action on it.

I'm concerned that alup/puppet-rbenv is no longer maintained and that we should find a way to get in contact with the author, find an altertanitive module or fork our own version that works properly.

[andyleejordan]

I'm glad you brought that up. At the time of the original work it still seemed maintained and the most popularly used, but I've noticed some issues with it as well. I'm considering an attempted switch to jdowning/rbenv, as its latest release was July and it seems widely used.

[igalic]

seems to be quite decent.

[ergonlogic]

The Gitlab maintainers specifically state that they don't support rbenv for production use: https://gitlab.com/gitlab-org/gitlab-ce/blob/master/doc/install/installation.md

That said, the dependency on an rbenv Puppet module ought to be documented in the readme.

[atomaka]

@ergonlogic I noted this in the original pull request (https://github.com/sbadia/puppet-gitlab/pull/114#issuecomment-34018225), but support for the change was strong and it does function as expected. I'll take care of the README update this afternoon.

[ergonlogic]

Thanks @atomaka, I'd just found #114.

If it hasn't already, the working deployment method for rbenv (sourced from .bashrc, or whatever) should probably be communicated and/or documented upstream, to the gitlab maintainers.

[altvnk]

Due to some tips with RBENV i'm started using system-wide RVM (binary).

[sbadia]

So? We switch to jdowning/rbenv ?

[blkperl]

Sounds good to me

[igalic]

:+1:, with the caveat: i don't have the cycles to contribute currently :(

[igalic]

@JimPanic might have some time to fix it ;)

[igalic]

so, i just looked into replacing alup/rbenv with jdowning/rbenv, however, currently we are compiling three versions of ruby, for three pieces of software:

igalic@levix ~/src/puppet/sbadia-gitlab (git)-[rbenv-new] % ack rbenv::compile manifests
manifests/setup.pp
105:  rbenv::compile { 'gitlab/ruby':

manifests/ci/setup.pp
74:  rbenv::compile { 'gitlabci/ruby':

manifests/ci/runner.pp
57:  rbenv::compile { 'gitlab-ci-runner/ruby':

this works well with alup/rbenv, because it's just a bunch of (defined) types, but in jdowning/rbenv they all have a global configuration.

i pinged @alup on twitter, https://twitter.com/hirojin/status/522713407842443264 / https://twitter.com/hirojin/status/522713524431491072 - hope there'll be a reply on one channel or another.

[alup]

Hi, FYI I am planning to catch up (with puppet/rbenv) next week. I will take a look at this and other problems. Finally, I am going to upload a brand new release to puppetforge.

[igalic]

\o/

[lieutdan13]

Still running into this issue today. There has apparently been a better proposed fix for alup/puppet-rbenv#80 being alup/puppet-rbenv/pull/106. But again, the maintainer is unresponsive to the PR.

[alup]

@lieutdan13 just merged

[lieutdan13]

It appears that alup/puppet-rbenv#108 fixes this issue. Not alup/puppet-rbenv#106. I've updated my rbenv module and ran puppet on the affected machine without it producing any rbenv output.

Thanks @alup for the fix!

[igalic]

@lieutdan13 they are both now merged.

[sbadia]

108, 106 and 202/204 fixed, thanks all !

[andyleejordan]

Nice!